Army concerts gave him a taste for the stage. He made his stage debut in 1928 in Dr Syn and the following year became a stage director at the Stage Society.

He became a film star almost overnight when cast as a drill sergeant in the comedy Reluctant Heroes (1951) which he had played on stage. Directed by Jack Raymond, this was one of the most popular films in British cinemas in 1952. Also popular was Worm’s Eye View (1952), the film version of the stage comedy, with Diana Dors, also directed by Raymond. These two films saw Shiner voted Britain’s most popular local male star in cinemas in 1952 – having never made the list before.

In retirement he owned a pub at Blackboys in Sussex. British Pathe News filmed a newsreel of him in his pub, being visited by Jimmy Edwards, in 1954.

Shiner back to leads for Up to His Neck (1954) with Carstairs, Aunt Clara (1954) with Margaret Rutherford, See How They Run (1955), Keep It Clean (1956), Dry Rot (1956) and My Wife’s Family (1956). His role as Badger in Seagulls Over Sorrento was taken by Sid James, although he reprised it for the BBC in 1956 and 1961. He played in My Three Angels on stage in 1955.

He was the subject of This Is Your Life in 1958 when he was surprised by Eamonn Andrews at the BBC Television Theatre.

Shiner starred in the London production of Aladdin as Widow Twankey with Bob Monkhouse at the Coliseum in 1960.

Shiner suffered ill health during his last few years. In 1963 he moved from London to Eastbourne for his health. He died in hospital there in June 1966 leaving an estate of £30,955.